feat: add rate limit (429) handling to AuthenticationController
#6993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
changed the title
AuthenticationController
mathieuartu
changed the title
AuthenticationControllerAuthenticationController
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Nov 17, 2025
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.test.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.test.ts
Outdated
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/flow-srp.test.ts
Show resolved
Hide resolved
ccharly
approved these changes
Nov 17, 2025
mathieuartu
deleted the
feat/authentication-controller-429-throttling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Related to: MUL-1214
Checklist
Note
Adds 429-aware error handling with configurable retry/cooldown to SRP JWT auth and centralizes HTTP error parsing, with tests and changelog updates.
RateLimitedError(429) with cooldown andmaxLoginRetriesoptions inSRPJwtBearerAuth(#loginWithRetry, default cooldown 10s).handleErrorResponse, parsingRetry-Afterand throwingRateLimitedErroron 429.getNonce,authenticate,authorizeOIDC,pairIdentifiers,getUserProfileLineage.HTTP_STATUS_CODESandutils/time.delay.RateLimitedErrorwith optionalretryAfterMsandisRateLimitErrortype guard.flow-srp.test.tscovering retry with cooldown, exhausting retries, no-retry on non-429, and concurrent call coalescing.CHANGELOG.mdwith new 429 handling and retry behavior.Written by Cursor Bugbot for commit fb123d2. This will update automatically on new commits. Configure here.